Issue 491723002: Exclude shell_nacl_browser_delegate_unittest.cc on disable_nacl configuration

Issue 491723002: Exclude shell_nacl_browser_delegate_unittest.cc on disable_nacl configuration (Closed)

Created:
6 years, 4 months ago by tzik

Modified:
6 years, 4 months ago

Reviewers:
James Cook

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Exclude shell_nacl_browser_delegate_unittest.cc on disable_nacl configuration NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290751

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	extensions/shell/app_shell.gyp	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 11 (0 generated)

tzik

Hi, James. I'm building chrome on disable_nacl=1 configuration on my machine. And on that build, ...

6 years, 4 months ago (2014-08-20 03:08:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/491723002/20001

6 years, 4 months ago (2014-08-20 03:20:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/491723002/20001

6 years, 4 months ago (2014-08-20 03:36:41 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/491723002/20001

6 years, 4 months ago (2014-08-20 03:56:04 UTC) #10

commit-bot: I haz the power

6 years, 4 months ago (2014-08-20 03:57:08 UTC) #11

Message was sent while issue was closed.

Committed patchset #2 (20001) as 290751