Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 491693003: Remove the Notation interface (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove the Notation interface Neither Firefox Nightly nor IE11 has the Notation interface, and it doesn't actually do anything in Blink/WebKit. BUG=405525 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M LayoutTests/fast/dom/Window/get-set-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/dom-constructors.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/dom-constructors-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8NodeCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D Source/core/dom/Notation.h View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/core/dom/Notation.idl View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
PTAL. I think this is trivial so I'm skipping use counters and intents.
6 years, 4 months ago (2014-08-20 13:34:39 UTC) #1
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-20 15:59:38 UTC) #2
eseidel
lgtm Since this is part of DOM Level 2 or some other ancient spec, I ...
6 years, 4 months ago (2014-08-20 15:59:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/491693003/1
6 years, 4 months ago (2014-08-20 15:59:43 UTC) #4
philipj_slow
On 2014/08/20 15:59:38, eseidel wrote: > Since this is part of DOM Level 2 or ...
6 years, 4 months ago (2014-08-20 16:32:34 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-20 16:49:26 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 17:34:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180662

Powered by Google App Engine
This is Rietveld 408576698