chrome/common/extensions/docs/server2/fake_fetchers.py - Issue 491653002: Docserver: Use GitilesFileSystem instead of SubversionFileSystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/fake_fetchers.py

Issue 491653002: Docserver: Use GitilesFileSystem instead of SubversionFileSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/app_yaml_helper_test.py ('K') | « chrome/common/extensions/docs/server2/cron_servlet_test.py ('k') | chrome/common/extensions/docs/server2/fake_host_file_system_provider.py » ('j') | chrome/common/extensions/docs/templates/private/warning_master.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/fake_fetchers.py

diff --git a/chrome/common/extensions/docs/server2/fake_fetchers.py b/chrome/common/extensions/docs/server2/fake_fetchers.py

index 78f719d57de1a41d360201c5ce711741f4701309..885df4c613599837e4e07394e7627dd63141925e 100644

--- a/chrome/common/extensions/docs/server2/fake_fetchers.py

+++ b/chrome/common/extensions/docs/server2/fake_fetchers.py

@@ -82,8 +82,7 @@ _GITILES_BRANCH_BASE_RE = re.escape(url_constants.GITILES_BRANCH_BASE)

# NOTE: _GITILES_BRANCH_BASE_RE must be first, because _GITILES_BASE_RE is

# a more general pattern.

_GITILES_URL_RE = r'(%s|%s)/' % (_GITILES_BRANCH_BASE_RE, _GITILES_BASE_RE)

-_GITILES_URL_TO_COMMIT_PATTERN = re.compile(

- r'%s[^/]+\?format=JSON' % _GITILES_URL_RE)

+_GITILES_URL_TO_COMMIT_PATTERN = re.compile(r'%s[^/]+$' % _GITILES_URL_RE)

_GITILES_URL_TO_PATH_PATTERN = re.compile(r'%s.+?/(.*)' % _GITILES_URL_RE)

def _ExtractPathFromGitilesUrl(url):

return _GITILES_URL_TO_PATH_PATTERN.match(url).group(2)