Docserver: Use GitilesFileSystem instead of SubversionFileSystem

chrome/common/extensions/docs/server2/app_yaml_helper_test.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 from app_yaml_helper import AppYamlHelper
 from extensions_paths import SERVER2
 from host_file_system_provider import HostFileSystemProvider
@@ skipping 70 matching lines @@
     # we know it's always going to be backed by a MockFileSystem. The Provider
     # may decide to wrap it in caching etc.
     file_system_at_head = MockFileSystem(
         TestFileSystem(test_data, relative_to=SERVER2))
 
     def apply_update(update):
       update = MoveTo(SERVER2, update)
       file_system_at_head.Update(update)
       updates.append(update)
 
-    def host_file_system_constructor(branch, revision=None):
-      self.assertEqual('trunk', branch)
-      self.assertTrue(revision is not None)
+    def host_file_system_constructor(branch, commit=None):
+      self.assertEqual('master', branch)
+      self.assertTrue(commit is not None)
       return MockFileSystem.Create(
-          TestFileSystem(test_data, relative_to=SERVER2), updates[:revision])
+          TestFileSystem(test_data, relative_to=SERVER2), updates[:commit])

[not at google - send to devlin, 2014/08/26 22:52:23]

This won't work either, right? Or does it.. happen to work?

[ahernandez, 2014/08/26 23:35:56]

It works because in the test data and test file systems commits are just
integers (stat counts IIRC). All tests are currently passing btw, although that
probably doesn't make you very confident. I plan to run this patch on the dev
server to check if there are any hidden bugs. Still, like you mentioned before
I'm curious to see how this will run on the production server.

 
     object_store_creator = ObjectStoreCreator.ForTest()
     host_file_system_provider = HostFileSystemProvider(
         object_store_creator,
-        default_trunk_instance=file_system_at_head,
+        default_master_instance=file_system_at_head,
         constructor_for_test=host_file_system_constructor)
     helper = AppYamlHelper(object_store_creator, host_file_system_provider)
 
     def assert_is_up_to_date(version):
       self.assertTrue(helper.IsUpToDate(version),
                       '%s is not up to date' % version)
       self.assertRaises(ValueError,
                         helper.GetFirstRevisionGreaterThan, version)
 
     self.assertEqual(0, helper.GetFirstRevisionGreaterThan('0-5-0'))
@@ skipping 59 matching lines @@
     self.assertEqual(6, helper.GetFirstRevisionGreaterThan('2-1-0'))
     self.assertEqual(7, helper.GetFirstRevisionGreaterThan('2-2-0'))
     self.assertEqual(7, helper.GetFirstRevisionGreaterThan('2-3-0'))
     self.assertEqual(8, helper.GetFirstRevisionGreaterThan('2-4-0'))
     self.assertEqual(8, helper.GetFirstRevisionGreaterThan('2-5-0'))
     assert_is_up_to_date('2-6-0')
     assert_is_up_to_date('2-7-0')
 
 if __name__ == '__main__':
   unittest.main()