Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 491583004: Make CollateRevisionHistory handle git and svn at the same time. (Closed)

Created:
6 years, 4 months ago by zty
Modified:
6 years, 4 months ago
Reviewers:
agable, szager1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Project:
infra
Visibility:
Public.

Description

Make CollateRevisionHistory handle git and svn at the same time. BUG=337035 R=agable@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/b0b897c663e2a0b0e2f7553c111db8cd0262a394

Patch Set 1 #

Patch Set 2 : Fixed a bug where keyfunc throws exception when NOREV is passed. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M infra/services/lkgr_finder/lkgr_lib.py View 1 2 chunks +10 lines, -1 line 2 comments Download

Messages

Total messages: 8 (0 generated)
zty
please take a look, thanks.
6 years, 4 months ago (2014-08-20 04:25:43 UTC) #1
zty
ptal
6 years, 4 months ago (2014-08-20 18:58:50 UTC) #2
szager1
https://codereview.chromium.org/491583004/diff/20001/infra/services/lkgr_finder/lkgr_lib.py File infra/services/lkgr_finder/lkgr_lib.py (right): https://codereview.chromium.org/491583004/diff/20001/infra/services/lkgr_finder/lkgr_lib.py#newcode124 infra/services/lkgr_finder/lkgr_lib.py:124: if r is NOREV: agable and I can't understand ...
6 years, 4 months ago (2014-08-20 19:09:55 UTC) #3
zty
sent stack trace via email. https://codereview.chromium.org/491583004/diff/20001/infra/services/lkgr_finder/lkgr_lib.py File infra/services/lkgr_finder/lkgr_lib.py (right): https://codereview.chromium.org/491583004/diff/20001/infra/services/lkgr_finder/lkgr_lib.py#newcode124 infra/services/lkgr_finder/lkgr_lib.py:124: if r is NOREV: ...
6 years, 4 months ago (2014-08-20 19:55:46 UTC) #4
szager1
lgtm
6 years, 4 months ago (2014-08-20 22:51:07 UTC) #5
zty
The CQ bit was checked by zty@chromium.org
6 years, 4 months ago (2014-08-21 00:15:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/491583004/20001
6 years, 4 months ago (2014-08-21 00:15:41 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 00:16:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as b0b897c663e2a0b0e2f7553c111db8cd0262a394

Powered by Google App Engine
This is Rietveld 408576698