No longer accept unsigned cloud policy blobs.

No longer accept unsigned cloud policy blobs.

UMA stats show that >99% of users have migrated to signed cloud policy blobs,
so it's time to stop supporting unsigned blobs - anyone who still has an
unsigned blob on their machine will go through a policy refresh on their
next restart.

BUG=404664
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290801

[Andrew T Wilson (Slow), 2014-08-20 07:37:22]

PTAL

[Joao da Silva, 2014-08-20 07:45:05]

https://codereview.chromium.org/491513002/diff/1/components/policy/core/commo...
File components/policy/core/common/cloud/user_cloud_policy_store.cc (right):

https://codereview.chromium.org/491513002/diff/1/components/policy/core/commo...
components/policy/core/common/cloud/user_cloud_policy_store.cc:383: std::string
signing_key = "";
No need to initialize with "", the default ctor does the same

https://codereview.chromium.org/491513002/diff/1/components/policy/core/commo...
components/policy/core/common/cloud/user_cloud_policy_store.cc:394:
validator->ValidateCachedKey(cached_key->signing_key(),
Did you mean to use |signing_key| here?

https://codereview.chromium.org/491513002/diff/1/components/policy/core/commo...
components/policy/core/common/cloud/user_cloud_policy_store.cc:399:
validator->ValidateSignature(cached_key->signing_key(),
And here?

[Andrew T Wilson (Slow), 2014-08-20 08:22:04]

PTAL - cleaned up that code significantly.

[Joao da Silva, 2014-08-20 08:32:50]

lgtm

[Andrew T Wilson (Slow), 2014-08-20 08:38:28]

The CQ bit was checked by atwilson@chromium.org

[commit-bot: I haz the power, 2014-08-20 08:39:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/atwilson@chromium.org/491513002/20001

[commit-bot: I haz the power, 2014-08-20 10:08:56]

Committed patchset #2 (20001) as 290801