Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 491483005: Add ICAs for additional Cast devices. (Closed)

Created:
6 years, 4 months ago by mark a. foltz
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add ICAs for additional Cast devices. BUG=406537 Committed: https://crrev.com/428519ae787d5fc9b5e4e3ee2da2f0c30f5f3173 Cr-Commit-Position: refs/heads/master@{#291590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -0 lines) Patch
M extensions/browser/api/cast_channel/cast_auth_util_nss.cc View 2 chunks +396 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mark a. foltz
6 years, 4 months ago (2014-08-22 21:48:15 UTC) #1
Wez
Rubber-stamp LGTM.
6 years, 4 months ago (2014-08-22 22:14:47 UTC) #2
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 4 months ago (2014-08-22 22:20:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/491483005/1
6 years, 4 months ago (2014-08-22 22:22:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 23:50:00 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-23 05:46:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as e762e2f1bf207ffd9be9f4988c660d9505f9db90
6 years, 4 months ago (2014-08-23 21:44:32 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:31:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/428519ae787d5fc9b5e4e3ee2da2f0c30f5f3173
Cr-Commit-Position: refs/heads/master@{#291590}

Powered by Google App Engine
This is Rietveld 408576698