Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: mojo/application_manager/application_manager.h

Issue 491443005: Get rid of KeepAlive. Quit shell when all urls run directly by Context are closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bring back ConnectToServiceViaNetwork Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/application_manager/application_manager.cc » ('j') | mojo/shell/context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application_manager/application_manager.h
diff --git a/mojo/application_manager/application_manager.h b/mojo/application_manager/application_manager.h
index bb58c1a8553d7cc87d7488cef11f1a7306336d74..01f31634e6362b8e1371b32d618411a1ec9c9f9f 100644
--- a/mojo/application_manager/application_manager.h
+++ b/mojo/application_manager/application_manager.h
@@ -20,6 +20,11 @@ namespace mojo {
class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
public:
+ class Delegate {
+ public:
+ virtual void OnServiceError(const GURL& url) = 0;
tim (not reviewing) 2014/08/23 00:14:26 Please add a comment describing what a service err
DaveMoore 2014/08/24 22:31:11 Done and Done.
+ };
tim (not reviewing) 2014/08/23 00:14:27 Should have a virtual ~Delegate... (protected: if
DaveMoore 2014/08/24 22:31:11 Done.
+
// API for testing.
class MOJO_APPLICATION_MANAGER_EXPORT TestAPI {
public:
@@ -70,6 +75,8 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
const GURL& application_url,
const std::string& interface_name);
+ void set_delegate(Delegate* delegate) { delegate_ = delegate; }
tim (not reviewing) 2014/08/23 00:14:27 Do we need to support the NULL-delegate case or co
DaveMoore 2014/08/24 22:31:11 I don't think so. It's up to the creator of the Ap
+
// Sets the default Loader to be used if not overridden by SetLoaderForURL()
// or SetLoaderForScheme().
void set_default_loader(scoped_ptr<ApplicationLoader> loader) {
@@ -122,6 +129,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
// Removes a ShellImpl when it encounters an error.
void OnShellImplError(ShellImpl* shell_impl);
+ Delegate* delegate_;
// Loader management.
URLToLoaderMap url_to_loader_;
SchemeToLoaderMap scheme_to_loader_;
« no previous file with comments | « no previous file | mojo/application_manager/application_manager.cc » ('j') | mojo/shell/context.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698