Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: mojo/shell/shell_test_base.h

Issue 491443005: Get rid of KeepAlive. Quit shell when all urls run directly by Context are closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SHELL_SHELL_TEST_BASE_H_ 5 #ifndef MOJO_SHELL_SHELL_TEST_BASE_H_
6 #define MOJO_SHELL_SHELL_TEST_BASE_H_ 6 #define MOJO_SHELL_SHELL_TEST_BASE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 21 matching lines...) Expand all
32 32
33 virtual void SetUp() OVERRIDE; 33 virtual void SetUp() OVERRIDE;
34 34
35 // |application_url| should typically be a mojo: URL (the origin will be set 35 // |application_url| should typically be a mojo: URL (the origin will be set
36 // to an "appropriate" file: URL). 36 // to an "appropriate" file: URL).
37 // TODO(tim): Should the test base be a ServiceProvider? 37 // TODO(tim): Should the test base be a ServiceProvider?
38 ScopedMessagePipeHandle ConnectToService( 38 ScopedMessagePipeHandle ConnectToService(
39 const GURL& application_url, 39 const GURL& application_url,
40 const std::string& service_name); 40 const std::string& service_name);
41 41
42 ScopedMessagePipeHandle ConnectToServiceViaNetwork( 42 template <typename Interface>
43 const GURL& application_url, 43 void ConnectToService(const GURL& application_url,
44 const std::string& service_name); 44 InterfacePtr<Interface>* ptr) {
45 ptr->Bind(ConnectToService(application_url, Interface::Name_).Pass());
46 }
45 47
46 base::MessageLoop* message_loop() { return &message_loop_; } 48 base::MessageLoop* message_loop() { return &message_loop_; }
47 Context* shell_context() { return &shell_context_; } 49 Context* shell_context() { return &shell_context_; }
48 50
49 private: 51 private:
50 scoped_ptr<net::test_server::EmbeddedTestServer> test_server_; 52 scoped_ptr<net::test_server::EmbeddedTestServer> test_server_;
51 Context shell_context_; 53 Context shell_context_;
52 base::MessageLoop message_loop_; 54 base::MessageLoop message_loop_;
53 55
54 DISALLOW_COPY_AND_ASSIGN(ShellTestBase); 56 DISALLOW_COPY_AND_ASSIGN(ShellTestBase);
55 }; 57 };
56 58
57 } // namespace test 59 } // namespace test
58 } // namespace shell 60 } // namespace shell
59 } // namespace mojo 61 } // namespace mojo
60 62
61 #endif // MOJO_SHELL_SHELL_TEST_BASE_H_ 63 #endif // MOJO_SHELL_SHELL_TEST_BASE_H_
OLDNEW
« no previous file with comments | « mojo/shell/run.cc ('k') | mojo/shell/shell_test_base.cc » ('j') | mojo/shell/shell_test_base.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698