Issue 491363002: Improvements for MachMultiprocess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 491363002: Improvements for MachMultiprocess (Closed)

Created:
6 years, 4 months ago by Mark Mentovai

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Improvements for MachMultiprocess. This adds a pipe going in the other direction (parent to child). Initially, I didn’t think this was necessary, but it turned out to be needed for ProcessReader. Having the child wait on a pipe read is the easiest way to keep it alive until the parent is done with it. This also tests MachMultiprocess::ChildPID() in mach_multiprocess_test.cc. Both of these fell out of https://codereview.chromium.org/491963002/. TEST=util_test MachMultiprocess.MachMultiprocess R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4004e77ee945

Patch Set 1 #

Patch Set 2 : Add a pipe going in the other direction #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -37 lines)			Patch
M	util/test/mac/mach_multiprocess.h	View	1	2 chunks	+13 lines, -7 lines	0 comments	Download
M	util/test/mac/mach_multiprocess.cc	View	1	7 chunks	+49 lines, -23 lines	0 comments	Download
M	util/test/mac/mach_multiprocess_test.cc	View	1	2 chunks	+28 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

6 years, 4 months ago (2014-08-22 18:00:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 4004e77ee945 (presubmit successful).

Expand Messages | Collapse Messages