chrome/browser/chromeos/reset/metrics.h - Issue 491263002: UI flow rework for device reset options. Reset made available from gaia screen. Tests adapted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/reset/metrics.h

Issue 491263002: UI flow rework for device reset options. Reset made available from gaia screen. Tests adapted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/webui_login_view.cc ('k') | chrome/browser/resources/chromeos/login/oobe_screen.css » ('j') | chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/reset/metrics.h

diff --git a/chrome/browser/chromeos/reset/metrics.h b/chrome/browser/chromeos/reset/metrics.h

index 44f848d651d4cdd28179acbdd5636195d858a148..777b6e0d7cded00d9a413c05e639dd9aea88852d 100644

--- a/chrome/browser/chromeos/reset/metrics.h

+++ b/chrome/browser/chromeos/reset/metrics.h

@@ -13,16 +13,19 @@ enum DialogViewType {

// User invoked the dialog from options page.

DIALOG_FROM_OPTIONS,

+ // Invoked with shortcut. Requesting restart form.

+ DIALOG_SHORTCUT_RESTART_REQUIRED,

Dmitry Polukhin 2014/08/22 07:58:23 It seems that it is structure that is used in UMA

merkulova 2014/08/22 09:46:46 Done.

// Invoked with shortcut. Confirming form for powerwash.

DIALOG_SHORTCUT_CONFIRMING_POWERWASH_ONLY,

// Invoked with shortcut. Confirming form for powerwash and rollback.

DIALOG_SHORTCUT_CONFIRMING_POWERWASH_AND_ROLLBACK,

- // Invoked with shortcut. Offering form, rollback checkbox unavailable.

+ // Invoked with shortcut. Offering form, rollback option set.

DIALOG_SHORTCUT_OFFERING_ROLLBACK_UNAVAILABLE,

- // Invoked with shortcut. Offering form, rollback checkbox available.

+ // Invoked with shortcut. Offering form, rollback option not set.

DIALOG_SHORTCUT_OFFERING_ROLLBACK_AVAILABLE,

// Must be last enum element.