Issue 491243003: Add another special rule for Windows headers to tools/sort-headers.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 491243003: Add another special rule for Windows headers to tools/sort-headers.py. (Closed)

Created:
6 years, 4 months ago by Lei Zhang

Modified:
6 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add another special rule for Windows headers to tools/sort-headers.py. NOTRY=true Committed: https://crrev.com/c5d3295f9cad0defb23b19f2034fc3609bc448c2 Cr-Commit-Position: refs/heads/master@{#291774}

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tools/sort-headers.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Lei Zhang

thestig@chromium.org changed reviewers: + scottmg@chromium.org

6 years, 4 months ago (2014-08-25 22:17:23 UTC) #1

Lei Zhang

Putting intshcut.h ahead of ole2.h breaks ie_importer_win.cc: http://goo.gl/X33tpV

6 years, 4 months ago (2014-08-25 22:17:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/491243003/1

6 years, 4 months ago (2014-08-25 22:29:58 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 86aa69022e08ec5c6b8c0be5bec065e33eb716d1

6 years, 4 months ago (2014-08-25 22:32:46 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:38:03 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c5d3295f9cad0defb23b19f2034fc3609bc448c2
Cr-Commit-Position: refs/heads/master@{#291774}