Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issue 491183002: Revert of Only show the checkbox for all urls when the switch is on (Closed)

Created:
6 years, 4 months ago by dewittj
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Only show the checkbox for all urls when the switch is on (patchset #2 of https://codereview.chromium.org/487913004/) Reason for revert: Conflicts with r290971 Original issue's description: > Only show the checkbox for all urls when the switch is on > BUG=402958 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290966 TBR=kalman@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true BUG=402958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -111 lines) Patch
M chrome/browser/extensions/extension_ui_unittest.cc View 5 chunks +0 lines, -108 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dewittj
Created Revert of Only show the checkbox for all urls when the switch is on
6 years, 4 months ago (2014-08-21 03:44:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/491183002/1
6 years, 4 months ago (2014-08-21 03:45:57 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 03:47:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 290987

Powered by Google App Engine
This is Rietveld 408576698