It2Me native messaging: GYP and source refactoring

remoting/webapp/host_native_messaging.js

Index: remoting/webapp/host_native_messaging.js
diff --git a/remoting/webapp/host_native_messaging.js b/remoting/webapp/host_native_messaging.js
index 8c76c424a3f535e45d05498212683b89b56af6f5..b51111870fd3e95f19a9b11e0e65bd0cc3eb739d 100644
--- a/remoting/webapp/host_native_messaging.js
+++ b/remoting/webapp/host_native_messaging.js
@@ -29,7 +29,7 @@ remoting.HostNativeMessaging = function() {
   this.pendingReplies_ = {};
 
   /** @type {?chrome.extension.Port} @private */
-  this.port_ = null;
+  this.me2mePort_ = null;

[Sergey Ulanov, 2013/10/30 22:51:01]

I don't think you really need this change. It's better to keep
HostNativeMessaging dedicated to the me2me native messaging and add a spearate
class for it2me. The plugin is currently is instantiated separately for It2Me
and Me2Me. HostDispatcher which creates HostNativeMessaging is used only in
Me2Me case.
You will need to change host_session.js to abstract the plugin and use native
messaging when it's available.

 
   /** @type {string} @private */
   this.version_ = '';
@@ -82,10 +82,10 @@ remoting.HostNativeMessaging.prototype.initialize = function(onDone, onError) {
   }
 
   try {
-    this.port_ = chrome.runtime.connectNative(
+    this.me2mePort_ = chrome.runtime.connectNative(
         'com.google.chrome.remote_desktop');
-    this.port_.onMessage.addListener(this.onIncomingMessage_.bind(this));
-    this.port_.onDisconnect.addListener(this.onDisconnect_.bind(this));
+    this.me2mePort_.onMessage.addListener(this.onIncomingMessage_.bind(this));
+    this.me2mePort_.onDisconnect.addListener(this.onDisconnect_.bind(this));
     this.postMessage_({type: 'hello'}, onDone,
                       onError.bind(null, remoting.Error.UNEXPECTED));
   } catch (err) {
@@ -177,7 +177,7 @@ remoting.HostNativeMessaging.prototype.postMessage_ =
   message['id'] = id;
   this.pendingReplies_[id] = new remoting.HostNativeMessaging.PendingReply(
     message.type + 'Response', onDone, onError);
-  this.port_.postMessage(message);
+  this.me2mePort_.postMessage(message);
 };
 
 /**