chrome/browser/extensions/api/web_request/web_request_api_helpers.h - Issue 491123004: Make sure that HttpRequestHeaders contains valid key-value pairs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.h

Issue 491123004: Make sure that HttpRequestHeaders contains valid key-value pairs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_helpers.cc » ('j') | net/http/http_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.h

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.h b/chrome/browser/extensions/api/web_request/web_request_api_helpers.h

index 1fac04e22ed9f46343c9eb579e9dcceca07d35b9..dc06eddaa4a960f99428056cb4220d98abab9d4f 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.h

+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.h

@@ -326,11 +326,6 @@ void NotifyWebRequestAPIUsed(

void* profile_id,

scoped_refptr<const extensions::Extension> extension);

-// Whether a header is RFC 2616-compliant.

-bool IsValidHeaderName(const std::string& name);

-// Whether a header value does not contain NUL or CRLF.

-bool IsValidHeaderValue(const std::string& value);

} // namespace extension_web_request_api_helpers

#endif // CHROME_BROWSER_EXTENSIONS_API_WEB_REQUEST_WEB_REQUEST_API_HELPERS_H_