Make sure that HttpRequestHeaders contains valid key-value pairs.

Make sure that HttpRequestHeaders contains valid key-value pairs.

Tracked down all uses of SetHeader() and SetHeaderIfMissing() and added
input validation where necessary (using the new IsValidHeader{Name,Value}
methods in http_util, moved from web_request_api_helpers).
After that, I added a DCHECK which serves as documentation to the users
of http_request_headers: The input must not contain illegal characters.

BUG=390458
Committed: https://crrev.com/7aad4986b5ab03e70d7390e99f3f2e9da6b521ae
Cr-Commit-Position: refs/heads/master@{#291761}

[robwu, 2014-08-24 10:30:15]

mmenke:
Could you review my changes to net?

Jam:
As a part of this CL I fixed all invalid header setters. Could you review
chrome/browser/extensions/* and chrome/common/chrome_content_client.cc ?

[jam, 2014-08-25 02:09:44]

lgtm

[mmenke, 2014-08-25 16:32:44]

https://codereview.chromium.org/491123004/diff/120001/net/http/http_util.h
File net/http/http_util.h (right):

https://codereview.chromium.org/491123004/diff/120001/net/http/http_util.h#ne...
net/http/http_util.h:81: // Returns true if |value| is a valid HTTP header
value.
This isn't accurate.  It doesn't do a full validation (For example, it doesn't
check for control characters).

Maybe "Returns false if |value| contains vertical white space or NULs.  Does not
do a full validity check."

[robwu, 2014-08-25 18:58:29]

https://codereview.chromium.org/491123004/diff/120001/net/http/http_util.h
File net/http/http_util.h (right):

https://codereview.chromium.org/491123004/diff/120001/net/http/http_util.h#ne...
net/http/http_util.h:81: // Returns true if |value| is a valid HTTP header
value.
On 2014/08/25 16:32:44, mmenke wrote:
> This isn't accurate.  It doesn't do a full validation (For example, it doesn't
> check for control characters).
> 
> Maybe "Returns false if |value| contains vertical white space or NULs.  Does
not
> do a full validity check."

Done.

[mmenke, 2014-08-25 19:01:19]

LGTM

[robwu, 2014-08-25 19:22:05]

The CQ bit was checked by rob@robwu.nl

[commit-bot: I haz the power, 2014-08-25 19:23:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob@robwu.nl/491123004/140001

[commit-bot: I haz the power, 2014-08-25 20:21:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-25 21:13:32]

Committed patchset #2 (140001) as ba2161d37bd6f18f609046561309c582d4219e73

[commit-bot: I haz the power, 2014-09-10 02:37:34]

Patchset 2 (id:??) landed as
https://crrev.com/7aad4986b5ab03e70d7390e99f3f2e9da6b521ae
Cr-Commit-Position: refs/heads/master@{#291761}