Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 491123002: GN: fix bootstrap.py due to recent changes in //base (Closed)

Created:
6 years, 4 months ago by kal
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: fix bootstrap.py due to recent changes in //base NOTRY=true R=brettw@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kal
6 years, 4 months ago (2014-08-20 21:02:23 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-20 22:25:08 UTC) #2
kal
The CQ bit was checked by kcconley@gmail.com
6 years, 4 months ago (2014-08-20 22:36:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kcconley@gmail.com/491123002/1
6 years, 4 months ago (2014-08-20 22:37:06 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 22:39:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (1) as 290931

Powered by Google App Engine
This is Rietveld 408576698