Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 491103004: Support scoped_ptr in BrowserThread::DeleteOnThread. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Support scoped_ptr in BrowserThread::DeleteOnThread. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291149

Patch Set 1 #

Patch Set 2 : Wed Aug 20 18:10:48 PDT 2014 #

Patch Set 3 : Wed Aug 20 18:12:19 PDT 2014 #

Patch Set 4 : Thu Aug 21 03:07:17 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M chrome/browser/local_discovery/pwg_raster_converter.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/printing/pdf_to_emf_converter.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_thread.h View 3 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-21 01:13:11 UTC) #1
Avi (use Gerrit)
lgtm Slick!
6 years, 4 months ago (2014-08-21 01:49:17 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 10:08:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/491103004/60001
6 years, 4 months ago (2014-08-21 10:09:16 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 10:09:28 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 17:49:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/491103004/60001
6 years, 4 months ago (2014-08-21 17:51:37 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 19:05:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (60001) as 291149

Powered by Google App Engine
This is Rietveld 408576698