Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 491079: Reapply "wait for connection" feature implementation (Closed)

Created:
8 years ago by Peter Rybin
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reapply "wait for connection" feature implementation Committed: http://code.google.com/p/v8/source/detail?r=3500

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Comment #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M include/v8-debug.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/debug.cc View 1 chunk +18 lines, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
Peter Rybin
Hi Sorren This one I checked with both release/debug tests. However, 2 tests look flaky ...
7 years, 12 months ago (2009-12-17 18:53:02 UTC) #1
Søren Thygesen Gjesse
7 years, 12 months ago (2009-12-18 11:01:19 UTC) #2
LGTM

I guess that the flakey tests give a TIMEOUT error. They can do that when run
locally depending on the machine used and on whether -j<something> is used.

Powered by Google App Engine
This is Rietveld 0eb02b776