Chromium Code Reviews
Help | Chromium Project | Sign in
(399)

Issue 491079: Reapply "wait for connection" feature implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Peter Rybin
Modified:
2 years, 11 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Reapply "wait for connection" feature implementation

Committed: http://code.google.com/p/v8/source/detail?r=3500

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Comment #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Lint Patch
M include/v8-debug.h View 1 2 1 chunk +4 lines, -1 line 0 comments 0 errors Download
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M src/debug.h View 1 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M src/debug.cc View 1 chunk +18 lines, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Peter Rybin
Hi Sorren This one I checked with both release/debug tests. However, 2 tests look flaky ...
4 years, 4 months ago #1
Søren Thygesen Gjesse
4 years, 4 months ago #2
LGTM

I guess that the flakey tests give a TIMEOUT error. They can do that when run
locally depending on the machine used and on whether -j<something> is used.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6