Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 491053007: Revert 291432 "NaCl: Update revision in DEPS, r13637 -> r13647" (Closed)

Created:
6 years, 4 months ago by gene
Modified:
6 years, 4 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 291432 "NaCl: Update revision in DEPS, r13637 -> r13647" > NaCl: Update revision in DEPS, r13637 -> r13647 > > This pulls in the following Native Client changes: > > r13638: (sbc) Update glibc revision in tools/REVISIONS (9b15f6a->150657d) > r13639: (mseaborn) PNaCl dynamic loading: Add ELF dynamic loader > r13640: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13641: (mseaborn) Use uint32_t for untrusted pointer args: fstat() and some other syscalls > r13642: (dschuff) Build PNaCl target libraries on mac and run SCons tests on the toolchain bot > r13643: (petarj) [MIPS] Change output-format to elf32-tradlittlemips-nacl > r13644: (petarj) PNaCl: Update binutils revision in pnacl/COMPONENT_REVISIONS > r13645: (mseaborn) Use uint32_t for untrusted pointer args: gettimeofday() syscall > r13646: (yyanagisawa) Re-enable use of goma on Windows. > r13647: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build > TBR=jam@chromium.org > > Review URL: https://codereview.chromium.org/474113003 TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gene
6 years, 4 months ago (2014-08-22 17:51:22 UTC) #1
gene
Committed patchset #1 manually as r291441 (tree was closed).
6 years, 4 months ago (2014-08-22 17:51:30 UTC) #2
Mark Seaborn
What was the reason for the revert?
6 years, 4 months ago (2014-08-22 19:00:36 UTC) #3
jabdelmalek
6 years, 4 months ago (2014-08-22 19:28:01 UTC) #4
Message was sent while issue was closed.
On 2014/08/22 19:00:36, Mark Seaborn wrote:
> What was the reason for the revert?

i asked on irc and got pointed to
http://build.chromium.org/p/chromium/builders/Win/builds/23691/steps/compile/...
FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x86
remoting_client_plugin_nacl_target_build_newlib_pexe_6ae9e986e4207b25ae993ca073b78350..rsp
..\..\remoting
C:\b\build\slave\Win\build\src\out\Release\gen\sdk\win_x86\pnacl_newlib\host_x86_32\bin\le32-nacl-ld.gold.exe:
error: ../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: member at
2888434 is not an ELF object

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_finish_mac'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_init_finished_mac'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_digest_cached_records'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_cleanup_key_block'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_generate_master_secret'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'n_ssl3_mac'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_enc'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_cert_verify_mac'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_alert_code'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_free_digest_list'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_change_cipher_state'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_setup_key_block'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_final_finish_mac'

../out/Release/gen/tc_pnacl_newlib/lib/libboringssl_nacl.a: error: undefined
reference to 'ssl3_record_sequence_update'

..\out\Release\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang++ -o
../out/Release/remoting_client_plugin_newlib.pexe.debug -Wl,--as-needed
../out/Release/obj/remoting/remoting_client_plugin_nacl.gen/pnacl_newlib/remoting_client_plugin_nacl/pepper_module_72e86210.o
-B../out/Release/gen/tc_pnacl_newlib/lib -O3 -lppapi_stub
-lremoting_client_plugin_lib_nacl -lremoting_proto_nacl -ljingle_glue_nacl
-lmedia_yuv_nacl -lnet_nacl -lcrypto_nacl -lbase_i18n_nacl -lbase_nacl
-lurl_nacl -lremoting_webrtc_nacl -lyuv_nacl -lvpx_nacl
-ljingle_p2p_constants_nacl -ljingle_nacl -lexpat_nacl -lmodp_b64_nacl
-lopus_nacl -lboringssl_nacl -licui18n_nacl -licuuc_nacl -licudata_nacl
-lprotobuf_lite_nacl -lwebm_nacl -lppapi_cpp -lpthread -lnacl_io

FAILED: Command '..\out\Release\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang++
-o ../out/Release/remoting_client_plugin_newlib.pexe.debug -Wl,--as-needed
../out/Release/obj/remoting/remoting_client_plugin_nacl.gen/pnacl_newlib/remoting_client_plugin_nacl/pepper_module_72e86210.o
-B../out/Release/gen/tc_pnacl_newlib/lib -O3 -lppapi_stub
-lremoting_client_plugin_lib_nacl -lremoting_proto_nacl -ljingle_glue_nacl
-lmedia_yuv_nacl -lnet_nacl -lcrypto_nacl -lbase_i18n_nacl -lbase_nacl
-lurl_nacl -lremoting_webrtc_nacl -lyuv_nacl -lvpx_nacl
-ljingle_p2p_constants_nacl -ljingle_nacl -lexpat_nacl -lmodp_b64_nacl
-lopus_nacl -lboringssl_nacl -licui18n_nacl -licuuc_nacl -licudata_nacl
-lprotobuf_lite_nacl -lwebm_nacl -lppapi_cpp -lpthread -lnacl_io' returned
non-zero exit status 1

Powered by Google App Engine
This is Rietveld 408576698