Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 491053002: Add back the duplicate property checker (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev, wingo
Project:
v8
Visibility:
Public.

Description

Add back the duplicate property checker We're not quite ready to make this change. BUG=v8:3498 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23284

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -121 lines) Patch
M src/preparser.h View 8 chunks +97 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +19 lines, -31 lines 0 comments Download
M test/mjsunit/strict-mode.js View 2 chunks +42 lines, -46 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -11 lines 0 comments Download
M test/webkit/object-literal-syntax.js View 1 chunk +14 lines, -14 lines 0 comments Download
M test/webkit/object-literal-syntax-expected.txt View 2 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
arv (Not doing code reviews)
This is mostly a revert from the old CL. The only difference is that the ...
6 years, 4 months ago (2014-08-20 17:49:10 UTC) #1
rossberg
On 2014/08/20 17:49:10, arv wrote: > This is mostly a revert from the old CL. ...
6 years, 4 months ago (2014-08-21 11:19:43 UTC) #2
arv (Not doing code reviews)
On 2014/08/21 at 11:19:43, rossberg wrote: > On 2014/08/20 17:49:10, arv wrote: > > This ...
6 years, 4 months ago (2014-08-21 15:16:46 UTC) #3
rossberg
On 2014/08/21 15:16:46, arv wrote: > On 2014/08/21 at 11:19:43, rossberg wrote: > > On ...
6 years, 4 months ago (2014-08-21 15:20:03 UTC) #4
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-21 15:32:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as 23284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698