Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 491043002: Make class lookup lazy in jni_generator when using lazy method lookup. (Closed)

Created:
6 years, 4 months ago by mkosiba (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make class lookup lazy in jni_generator when using lazy method lookup. This removes the eager class registration from RegisterNatives when possible. BUG=402003 TBR=sievers@chromium.org, brettw@chromium.org, torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291095

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -370 lines) Patch
M android_webview/lib/main/webview_entry_point.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M base/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M base/android/base_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/JNIUtils.java View 1 chunk +20 lines, -0 lines 0 comments Download
M base/android/jni_android.h View 2 chunks +20 lines, -0 lines 0 comments Download
M base/android/jni_android.cc View 3 chunks +56 lines, -1 line 0 comments Download
M base/android/jni_generator/golden_sample_for_tests_jni.h View 14 chunks +28 lines, -25 lines 0 comments Download
M base/android/jni_generator/jni_generator.py View 1 7 chunks +32 lines, -13 lines 0 comments Download
M base/android/jni_generator/testCalledByNatives.golden View 22 chunks +43 lines, -41 lines 0 comments Download
M base/android/jni_generator/testConstantsFromJavaP.golden View 88 chunks +194 lines, -193 lines 0 comments Download
M base/android/jni_generator/testEagerCalledByNativesOption.golden View 7 chunks +12 lines, -10 lines 0 comments Download
M base/android/jni_generator/testFromJavaP.golden View 12 chunks +24 lines, -23 lines 0 comments Download
M base/android/jni_generator/testFromJavaPGenerics.golden View 3 chunks +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/testInnerClassNatives.golden View 3 chunks +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden View 3 chunks +6 lines, -5 lines 0 comments Download
M base/android/jni_generator/testInnerClassNativesMultiple.golden View 3 chunks +6 lines, -5 lines 0 comments Download
M base/android/jni_generator/testJNIInitNativeNameOption.golden View 3 chunks +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/testJarJarRemapping.golden View 3 chunks +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/testMultipleJNIAdditionalImport.golden View 5 chunks +8 lines, -7 lines 0 comments Download
M base/android/jni_generator/testNativeExportsOption.golden View 1 10 chunks +20 lines, -18 lines 0 comments Download
M base/android/jni_generator/testNatives.golden View 3 chunks +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/testNativesLong.golden View 3 chunks +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/testPureNativeMethodsOption.golden View 3 chunks +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/testSingleJNIAdditionalImport.golden View 5 chunks +8 lines, -7 lines 0 comments Download
A base/android/jni_utils.h View 1 chunk +27 lines, -0 lines 0 comments Download
A base/android/jni_utils.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/android/scoped_java_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mkosiba (inactive)
This is a re-land of https://codereview.chromium.org/472553002/ with a slight modification (using a macro instead of ...
6 years, 4 months ago (2014-08-20 17:54:12 UTC) #1
rmcilroy
lgtm with a nit. https://codereview.chromium.org/491043002/diff/1/base/android/jni_generator/jni_generator.py File base/android/jni_generator/jni_generator.py (right): https://codereview.chromium.org/491043002/diff/1/base/android/jni_generator/jni_generator.py#newcode1273 base/android/jni_generator/jni_generator.py:1273: &g_${JAVA_CLASS}_clazz)""") don't add the extra ...
6 years, 4 months ago (2014-08-21 09:34:09 UTC) #2
mkosiba (inactive)
https://codereview.chromium.org/491043002/diff/1/base/android/jni_generator/jni_generator.py File base/android/jni_generator/jni_generator.py (right): https://codereview.chromium.org/491043002/diff/1/base/android/jni_generator/jni_generator.py#newcode1273 base/android/jni_generator/jni_generator.py:1273: &g_${JAVA_CLASS}_clazz)""") On 2014/08/21 09:34:08, rmcilroy wrote: > don't add ...
6 years, 4 months ago (2014-08-21 09:51:20 UTC) #3
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 4 months ago (2014-08-21 09:51:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/491043002/20001
6 years, 4 months ago (2014-08-21 09:53:27 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 16:37:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291095

Powered by Google App Engine
This is Rietveld 408576698