Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issue 49103002: Return early from BinaryOpIC::Transition when the JS call failed (Closed)

Created:
7 years, 1 month ago by Jakob Kummerow
Modified:
7 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Return early from BinaryOpIC::Transition when the JS call failed This avoids an ASSERT failure in Chromium net_unittests. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/ic.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 1 month ago (2013-10-28 16:31:11 UTC) #1
Yang
lgtm.
7 years, 1 month ago (2013-10-28 16:31:50 UTC) #2
Jakob Kummerow
7 years, 1 month ago (2013-10-28 16:33:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17417.

Powered by Google App Engine
This is Rietveld 408576698