Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 491023005: Fix minidump_module_writer_test 32-bit x86 build (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Fix minidump_module_writer_test 32-bit x86 build. time_t is a typedef for long on Mac OS X. In 32-bit x86 (ILP32), long is a signed 32-bit quantity, and its range does not contain the range of uint32_t, used to store times in time_t fashion in minidump files. A cast is necessary to make these EXPECT_* macros do the right thing. This is not a problem in x86_64 (LP64) where long is a signed 64-bit quantity, which does contain the range of uint32_t. clang’s error was “error: comparison of integers of different signs: 'const long' and 'const unsigned int' [-Werror,-Wsign-compare]” BUG= R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9168ba47acf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M minidump/minidump_module_writer_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
Broken out from https://codereview.chromium.org/493563002.
6 years, 4 months ago (2014-08-20 22:30:03 UTC) #1
Robert Sesek
lgtm
6 years, 4 months ago (2014-08-20 22:31:32 UTC) #2
Mark Mentovai
6 years, 4 months ago (2014-08-20 22:32:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 9168ba47acf7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698