Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 491023004: Change the visibility of AutofillSuggestion member variables. (Closed)

Created:
6 years, 4 months ago by aurimas (slooooooooow)
Modified:
6 years, 4 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Change the visibility of AutofillSuggestion member variables. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/autofill/AutofillSuggestion.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
aurimas (slooooooooow)
PTAL
6 years, 4 months ago (2014-08-20 22:37:22 UTC) #1
aurimas (slooooooooow)
On 2014/08/20 22:37:22, aurimas wrote: > PTAL Ping?
6 years, 4 months ago (2014-08-21 21:45:24 UTC) #2
newt (away)
lgtm
6 years, 4 months ago (2014-08-21 21:49:45 UTC) #3
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 4 months ago (2014-08-21 21:55:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/491023004/1
6 years, 4 months ago (2014-08-21 21:57:30 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 23:25:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 23:31:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8240)
6 years, 4 months ago (2014-08-21 23:31:28 UTC) #8
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 4 months ago (2014-08-22 00:47:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/491023004/1
6 years, 4 months ago (2014-08-22 00:50:45 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:19:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 291294

Powered by Google App Engine
This is Rietveld 408576698