Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 491013004: Adjust border of the experimental app list search box. (Closed)

Created:
6 years, 4 months ago by calamity
Modified:
6 years, 3 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Adjust border of the experimental app list search box. This CL makes the bottom border of the experimental app list search box darker and thinner. BUG=406222 Committed: https://crrev.com/68d8540b9f4f7b5e56fffeb5aea138170d875b5a Cr-Commit-Position: refs/heads/master@{#292075}

Patch Set 1 #

Patch Set 2 : make border thinner, adjust constants #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/app_list/views/search_box_view.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
calamity
6 years, 4 months ago (2014-08-22 03:47:26 UTC) #1
tapted
lgtm, before/after screenshots on the bug are normally good too for history (and in case ...
6 years, 4 months ago (2014-08-22 04:54:14 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 4 months ago (2014-08-25 01:28:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/491013004/20001
6 years, 4 months ago (2014-08-25 01:28:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-25 01:36:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 01:37:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/45683) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/8513) ios_rel_device ...
6 years, 4 months ago (2014-08-25 01:37:27 UTC) #7
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 3 months ago (2014-08-27 01:01:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/491013004/40001
6 years, 3 months ago (2014-08-27 01:02:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (40001) as e5fecebf12b4648a9642b1a6b55973372e900423
6 years, 3 months ago (2014-08-27 01:57:03 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:00 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68d8540b9f4f7b5e56fffeb5aea138170d875b5a
Cr-Commit-Position: refs/heads/master@{#292075}

Powered by Google App Engine
This is Rietveld 408576698