Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 490943002: Use size_t in GCIdleTimeHandler to fix undefined behaviour. (Closed)

Created:
6 years, 4 months ago by Hannes Payer (out of office)
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use size_t in GCIdleTimeHandler to fix undefined behaviour. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23248

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -30 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 chunk +6 lines, -3 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/heap-unittests/heap-unittest.cc View 1 2 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-20 12:49:30 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-20 12:56:04 UTC) #2
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-20 15:37:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698