Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(507)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/css/get-matched-css-rules-set-selector-text.html
Issue
49093005
:
Fix memory error during selector matching due to getMatchedCSSRules. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments
Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/css/get-matched-css-rules-set-selector-text.html
LayoutTests/fast/css/get-matched-css-rules-set-selector-text-expected.html
Source/core/core.gypi
Source/core/css/CSSStyleSheet.h
Source/core/css/CSSStyleSheet.cpp
Source/core/css/ElementRuleCollector.h
Source/core/css/ElementRuleCollector.cpp
Source/core/css/resolver/StyleResolver.h
Source/core/css/resolver/StyleResolver.cpp
Source/core/css/resolver/StyleResolverIncludes.h
Source/core/inspector/InspectorCSSAgent.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« no previous file
|
LayoutTests/fast/css/get-matched-css-rules-set-selector-text-expected.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<style>
3
html, img { border: 5px solid salmon; }
4
</style>
5
<script>
6
function eventhandler() {
7
window.getMatchedCSSRules(document.documentElement)[0].selectorText = 'div';
8
document.documentElement.offsetHeight; // Crash under ASAN was here in updat eStyleIfNeeded
9
}
10
</script>
11
<img>
12
<iframe onbeforeload="eventhandler()"></iframe>
13
<div>This div should be the only element with a 5px border.</div>
OLD
NEW
« no previous file with comments
|
« no previous file
|
LayoutTests/fast/css/get-matched-css-rules-set-selector-text-expected.html »
('j') |
no next file with comments »
Issue 49093005: Fix memory error during selector matching due to getMatchedCSSRules. (Closed)
Created 7 years, 1 month ago by ojan
Modified 7 years, 1 month ago
Reviewers: esprehn, eseidel
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 9
This is Rietveld
408576698