Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 49093004: Move more arrays of strings to shareable memory (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium, digit1
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, bemjb+rendering_chromium.org, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, nessy, loislo+blink_chromium.org, zoltan1, philipj_slow, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, darktears, haraken, kojih, vcarbune.chromium, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move more arrays of strings to shareable memory Move more arrays of strings to shareable memory (either .rodata or .data.rel.ro) to potentially reduce RAM usage on Android. This is done by using char arrays instead of pointers when possible or by marking the pointer as const when this is not possible. This also reduces the number of relocations (by getting rid of the pointers), which makes loading the library faster. BUG=249746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160835

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTextControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketDeflater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/TextBreakIteratorICU.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/UnicodeRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years, 1 month ago (2013-10-28 20:16:31 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/49093004/diff/1/Source/bindings/v8/DateExtension.cpp File Source/bindings/v8/DateExtension.cpp (right): https://codereview.chromium.org/49093004/diff/1/Source/bindings/v8/DateExtension.cpp#newcode44 Source/bindings/v8/DateExtension.cpp:44: static const char dateExtensionScript[] = This code is ...
7 years, 1 month ago (2013-10-29 05:21:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/49093004/1
7 years, 1 month ago (2013-10-29 05:21:29 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/html/shadow/MediaControlElements.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-10-29 05:21:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/49093004/100001
7 years, 1 month ago (2013-10-29 14:12:17 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 15:04:00 UTC) #6
Message was sent while issue was closed.
Change committed as 160835

Powered by Google App Engine
This is Rietveld 408576698