Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 490923006: Cleanup BrowserPluginGuestManager (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup BrowserPluginGuestManager Remove some unnecessary includes, typedefs, and forward declarations. BUG=none Committed: https://crrev.com/e17795cf3274d815bd2e7705b66e99d314c4767f Cr-Commit-Position: refs/heads/master@{#292318}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/public/browser/browser_plugin_guest_manager.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/public/browser/browser_plugin_guest_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Fady Samuel
fsamuel@chromium.org changed reviewers: + creis@chromium.org
6 years, 3 months ago (2014-08-27 22:13:39 UTC) #1
Fady Samuel
6 years, 3 months ago (2014-08-27 22:13:39 UTC) #2
Charlie Reis
Thanks for the cleanup. LGTM.
6 years, 3 months ago (2014-08-27 22:30:35 UTC) #3
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-27 22:33:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/490923006/1
6 years, 3 months ago (2014-08-27 22:34:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 23:32:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:02:39 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:02:40 UTC) #8
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-28 01:08:11 UTC) #9
Fady Samuel
The CQ bit was unchecked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-28 01:08:11 UTC) #10
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-28 01:08:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/490923006/1
6 years, 3 months ago (2014-08-28 01:09:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:11:54 UTC) #13
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:11:54 UTC) #14
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-28 02:35:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/490923006/20001
6 years, 3 months ago (2014-08-28 02:36:18 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-28 03:39:30 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4370e7bace43841128476877c049c2b0409b2c98
6 years, 3 months ago (2014-08-28 04:25:52 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:27 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e17795cf3274d815bd2e7705b66e99d314c4767f
Cr-Commit-Position: refs/heads/master@{#292318}

Powered by Google App Engine
This is Rietveld 408576698