Make EXTRACT_LOCAL and EXTRACT_METHOD refactorings available when there is a selection.

pkg/analysis_server/test/edit/refactoring_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.edit.refactoring;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/edit/edit_domain.dart' hide RefactoringKind;
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 13 matching lines @@
 
 
 @ReflectiveTestCase()
 class GetAvailableRefactoringsTest extends AbstractAnalysisTest {
   /**
    * Tests that there is a RENAME refactoring available at the [search] offset.
    */
   Future assertHasRenameRefactoring(String code, String search) {
     addTestFile(code);
     return waitForTasksFinished().then((_) {
-      List<RefactoringKind> kinds = getAvailableRefactorings(search);
+      List<RefactoringKind> kinds = getRefactoringsAtString(search);
       expect(kinds, contains(RefactoringKind.RENAME));
     });
   }
 
   /**
-   * Returns the list of available refactorings of the offset of [search] with
-   * [length] characters selected.
+   * Returns the list of available refactorings for the given [offset] and
+   * [length].
    */
-  List<RefactoringKind> getAvailableRefactorings(String search, [int length = 0]) {
-    Request request = new EditGetAvailableRefactoringsParams(testFile,
-        findOffset(search), length).toRequest('0');
+  List<RefactoringKind> getRefactorings(int offset, int length) {
+    Request request = new EditGetAvailableRefactoringsParams(
+        testFile,
+        offset,
+        length).toRequest('0');
     Response response = handleSuccessfulRequest(request);
     var result = new EditGetAvailableRefactoringsResult.fromResponse(response);
     return result.kinds;
   }
 
+  /**
+   * Returns the list of available refactorings at the offset of [search].
+   */
+  List<RefactoringKind> getRefactoringsAtString(String search) {
+    int offset = findOffset(search);
+    return getRefactorings(offset, 0);
+  }
+
+  List<RefactoringKind> getRefactoringsForString(String search) {
+    int offset = findOffset(search);
+    return getRefactorings(offset, search.length);
+  }
+
   @override
   void setUp() {
     super.setUp();
     createProject();
     handler = new EditDomainHandler(server);
   }
 
+  Future test_extractLocal() {
+    addTestFile('''
+main() {
+  var a = 1 + 2;
+}
+''');
+    return waitForTasksFinished().then((_) {
+      var search = '1 + 2';
+      List<RefactoringKind> kinds = getRefactoringsForString(search);
+      expect(kinds, contains(RefactoringKind.EXTRACT_LOCAL_VARIABLE));
+      expect(kinds, contains(RefactoringKind.EXTRACT_METHOD));
+    });
+  }
+
   Future test_rename_hasElement_class() {
     return assertHasRenameRefactoring('''
 class Test {}
 main() {
   Test v;
 }
 ''', 'Test v');
   }
 
   Future test_rename_hasElement_constructor() {
@@ skipping 92 matching lines @@
 ''', 'test();');
   }
 
   Future test_rename_noElement() {
     addTestFile('''
 main() {
   // not an element
 }
 ''');
     return waitForTasksFinished().then((_) {
-      List<RefactoringKind> kinds = getAvailableRefactorings('// not an element');
+      List<RefactoringKind> kinds =
+          getRefactoringsAtString('// not an element');
       expect(kinds, isNot(contains(RefactoringKind.RENAME)));
     });
   }
 }