Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: tests/lib/mirrors/parameter_metadata_test.dart

Issue 49083004: Re-triage mirror test failures on the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/mixin_members_test.dart ('k') | tests/lib/mirrors/private_symbol_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/parameter_metadata_test.dart
diff --git a/tests/lib/mirrors/parameter_metadata_test.dart b/tests/lib/mirrors/parameter_metadata_test.dart
index f27a149dce1ff2c0ba58f332b364ac1381b84ac8..fdb1fc61e586c39eaee3f100d5e367ff2f7a1333 100644
--- a/tests/lib/mirrors/parameter_metadata_test.dart
+++ b/tests/lib/mirrors/parameter_metadata_test.dart
@@ -19,15 +19,15 @@ class CustomAnnotation {
}
class B {
- B.foo(int x);
- factory B.bar(@m3 @m2 int z, x){}
+ B.foo(int x) {}
+ factory B.bar(@m3 @m2 int z, x) {}
- baz(@m1 final int x, @m2 int y, @m3 final int z);
- qux(int x, [@m3 @m2 @m1 int y= 3 + 1]);
- quux(int x, {String str: "foo"});
- corge({@m1 int x: 3 * 17, @m2 String str: "bar"});
+ baz(@m1 final int x, @m2 int y, @m3 final int z) {}
+ qux(int x, [@m3 @m2 @m1 int y= 3 + 1]) {}
+ quux(int x, {String str: "foo"}) {}
+ corge({@m1 int x: 3 * 17, @m2 String str: "bar"}) {}
- set x(@m2 final value);
+ set x(@m2 final value) {}
}
main() {
@@ -38,18 +38,18 @@ main() {
checkMetadata(cm.constructors[#B.bar].parameters[0], [m3, m2]);
checkMetadata(cm.constructors[#B.bar].parameters[1], []);
- checkMetadata(cm.members[#baz].parameters[0], [m1]);
- checkMetadata(cm.members[#baz].parameters[1], [m2]);
- checkMetadata(cm.members[#baz].parameters[2], [m3]);
+ checkMetadata(cm.methods[#baz].parameters[0], [m1]);
+ checkMetadata(cm.methods[#baz].parameters[1], [m2]);
+ checkMetadata(cm.methods[#baz].parameters[2], [m3]);
- checkMetadata(cm.members[#qux].parameters[0], []);
- checkMetadata(cm.members[#qux].parameters[1], [m3, m2, m1]);
+ checkMetadata(cm.methods[#qux].parameters[0], []);
+ checkMetadata(cm.methods[#qux].parameters[1], [m3, m2, m1]);
- checkMetadata(cm.members[#quux].parameters[0], []);
- checkMetadata(cm.members[#quux].parameters[1], []);
+ checkMetadata(cm.methods[#quux].parameters[0], []);
+ checkMetadata(cm.methods[#quux].parameters[1], []);
- checkMetadata(cm.members[#corge].parameters[0], [m1]);
- checkMetadata(cm.members[#corge].parameters[1], [m2]);
+ checkMetadata(cm.methods[#corge].parameters[0], [m1]);
+ checkMetadata(cm.methods[#corge].parameters[1], [m2]);
- checkMetadata(cm.members[const Symbol('x=')].parameters[0], [m2]);
+ checkMetadata(cm.setters[const Symbol('x=')].parameters[0], [m2]);
}
« no previous file with comments | « tests/lib/mirrors/mixin_members_test.dart ('k') | tests/lib/mirrors/private_symbol_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698