Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tests/lib/mirrors/generics_test.dart

Issue 49083004: Re-triage mirror test failures on the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/generics_helper.dart ('k') | tests/lib/mirrors/method_mirror_properties_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/generics_test.dart
diff --git a/tests/lib/mirrors/generics_test.dart b/tests/lib/mirrors/generics_test.dart
index 8eb63ee0536b8ec21ecaf76efd209ff9d4bdcb89..ec2d49a38946ad990dda14d9fe0656d8a3835f8a 100644
--- a/tests/lib/mirrors/generics_test.dart
+++ b/tests/lib/mirrors/generics_test.dart
@@ -7,13 +7,14 @@ library test.type_arguments_test;
import 'dart:mirrors';
import 'package:expect/expect.dart';
+import 'generics_helper.dart';
class A<T> {}
class Z<T> {}
-class B extends A {} // Same as class B extends A<dynamic>.
-class C extends A
-<num, int> // TODO(zarah): Should be "01: static warning".
-{} // Same as class C extends A<dynamic>.
+class B extends A {}
+class C
+ extends A<num, int> /// 01: static type warning
+ {}
class D extends A<int> {}
class E<S> extends A<S> {}
class F<R> extends A<int> {}
@@ -21,15 +22,6 @@ class G {}
class H<A,B,C> {}
class I extends G {}
-typeParameters(mirror, parameterNames) {
- Expect.listEquals(parameterNames,
- mirror.typeVariables.map((v) => v.simpleName).toList());
-}
-
-typeArguments(mirror, argumentMirrors) {
- Expect.listEquals(argumentMirrors, mirror.typeArguments);
-}
-
main() {
// Declarations.
typeParameters(reflectClass(A), [#T]);
@@ -75,7 +67,7 @@ main() {
// Instantiations.
typeParameters(reflect(new A<num>()).type, [#T]);
- typeParameters(reflect(new B<num>()).type, []);
+ typeParameters(reflect(new B()).type, []);
typeParameters(reflect(new C()).type, []);
typeParameters(reflect(new D()).type, []);
typeParameters(reflect(new E()).type, [#S]);
« no previous file with comments | « tests/lib/mirrors/generics_helper.dart ('k') | tests/lib/mirrors/method_mirror_properties_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698