Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: tests/lib/mirrors/reflect_class_test.dart

Issue 49083004: Re-triage mirror test failures on the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: multitest for bound warnings, rationales otherwise Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/private_symbol_test.dart ('k') | tests/lib/mirrors/reflected_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/reflect_class_test.dart
diff --git a/tests/lib/mirrors/reflect_class_test.dart b/tests/lib/mirrors/reflect_class_test.dart
index c556ba8a93c2831500ca00741481e39e3aba4272..7566a18efdb734840a71ddbb93848b5ffd2f0f21 100644
--- a/tests/lib/mirrors/reflect_class_test.dart
+++ b/tests/lib/mirrors/reflect_class_test.dart
@@ -12,10 +12,7 @@ main() {
Function expectedError = (e) => e is ArgumentError || e is TypeError;
Expect.throws(() => reflectClass(dynamic), expectedError);
- Expect.throws(() => reflectClass(1), expectedError);
- Expect.throws(() => reflectClass("string"), expectedError);
-
- // reflectClass() on a function type should fail once typedefs are represented
- // by TypedefMirrors instead of ClassMirrors.
- // Expect.throws(() => reflectClass(FooFunction), expectedError);
+ Expect.throws(() => reflectClass(1), expectedError); /// static type warning
+ Expect.throws(() => reflectClass("string"), expectedError); /// static type warning
kustermann 2013/10/28 23:04:17 what about these?
rmacnak 2013/10/29 00:04:15 Woops. Got 'em. More careful greping says the mirr
+ Expect.throws(() => reflectClass(FooFunction), expectedError);
}
« no previous file with comments | « tests/lib/mirrors/private_symbol_test.dart ('k') | tests/lib/mirrors/reflected_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698