Issue 490793003: Resubmit: Only show the checkbox for all urls when the switch is on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 490793003: Resubmit: Only show the checkbox for all urls when the switch is on (Closed)

Created:
6 years, 4 months ago by Devlin

Modified:
6 years, 4 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Resubmit: Only show the checkbox for all urls when the switch is on Original: https://codereview.chromium.org/487913004/ Reverted because of a conflict with a patch that landed after it. Only change is to use the new location for id_util (crx_file). Original Description: Only show the checkbox for all urls when the switch is on BUG=402958 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291212

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -1 line)			Patch
	M	chrome/browser/extensions/extension_ui_unittest.cc	View		5 chunks	+108 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/490793003/1

6 years, 4 months ago (2014-08-21 16:37:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (1) as 291212