Source/web/WebViewImpl.h - Issue 490783003: Reduce hit test on ShowPress by moving event targeting to WebViewImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 490783003: Reduce hit test on ShowPress by moving event targeting to WebViewImpl (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Switch back to using platform event position for content intents Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index f1e59bfce3d78dca21909aad9b2f77a3ed9378b4..967e2920f1c7ba6f17d143b829004bfa8b2cea0f 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -31,6 +31,7 @@

#ifndef WebViewImpl_h

#define WebViewImpl_h

+#include "core/page/EventWithHitTestResults.h"

#include "core/page/PagePopupDriver.h"

#include "platform/geometry/IntPoint.h"

#include "platform/geometry/IntRect.h"

@@ -439,8 +440,8 @@ public:

void fullFramePluginZoomLevelChanged(double zoomLevel);

void computeScaleAndScrollForBlockRect(const WebPoint& hitPoint, const WebRect& blockRect, float padding, float defaultScaleWhenAlreadyLegible, float& scale, WebPoint& scroll);

- Node* bestTapNode(const PlatformGestureEvent& tapEvent);

- void enableTapHighlightAtPoint(const PlatformGestureEvent& tapEvent);

+ Node* bestTapNode(const GestureEventWithHitTestResults& targetedTapEvent);

+ void enableTapHighlightAtPoint(const GestureEventWithHitTestResults& targetedTapEvent);

void enableTapHighlights(WillBeHeapVector<RawPtrWillBeMember<Node> >&);

void computeScaleAndScrollForFocusedNode(Node* focusedNode, float& scale, IntPoint& scroll, bool& needAnimation);

« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »