chrome/renderer/resources/extensions/extension_options_events.js - Issue 490783002: Handle closing web contents in ExtensionOptionsGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/extension_options_events.js

Issue 490783002: Handle closing web contents in ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests for detecting onclose event in WebUI Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_options_internal.idl ('k') | chrome/test/data/extensions/api_test/extension_options/close_self/manifest.json » ('j') | chrome/test/data/extensions/webui/receives_extension_options_on_close.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/extension_options_events.js

diff --git a/chrome/renderer/resources/extensions/extension_options_events.js b/chrome/renderer/resources/extensions/extension_options_events.js

index c842b08ed62b9b1780c5d97550454bfdf1c8791a..ded82cf0194207ff1d1e72bc0dcf5786bd68d730 100644

--- a/chrome/renderer/resources/extensions/extension_options_events.js

+++ b/chrome/renderer/resources/extensions/extension_options_events.js

@@ -10,6 +10,10 @@ var CreateEvent = function(name) {

};

var EXTENSION_OPTIONS_EVENTS = {

+ 'close': {

+ evt: CreateEvent('extensionOptionsInternal.onClose'),

+ fields: []

+ },

'load': {

evt: CreateEvent('extensionOptionsInternal.onLoad'),

fields: []