Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.js

Issue 490783002: Handle closing web contents in ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_options_overlay.js
diff --git a/chrome/browser/resources/extensions/extension_options_overlay.js b/chrome/browser/resources/extensions/extension_options_overlay.js
index 899098d625ec446767be32d832602b97367fd582..db03e08ce7f1e3af02e873b8dfba1ebb092c72db 100644
--- a/chrome/browser/resources/extensions/extension_options_overlay.js
+++ b/chrome/browser/resources/extensions/extension_options_overlay.js
@@ -47,9 +47,12 @@ cr.define('extensions', function() {
*/
handleDismiss_: function(event) {
this.setVisible_(false);
- var extensionoptions = document.querySelector('extensionoptions');
+ var extensionoptions =
+ $('extension-options-overlay-guest')
+ .querySelector('extensionoptions');
+
if (extensionoptions)
- $('extension-options-overlay').removeChild(extensionoptions);
+ $('extension-options-overlay-guest').removeChild(extensionoptions);
},
/**
@@ -64,13 +67,17 @@ cr.define('extensions', function() {
extensionoptions.extension = extensionId;
extensionoptions.autosize = 'on';
+ extensionoptions.onclose = function() {
+ this.handleDismiss_();
+ }.bind(this);
+
// TODO(ericzeng): Resize in a non-jarring way.
extensionoptions.onsizechanged = function(evt) {
$('extension-options-overlay').style.width = evt.width;
$('extension-options-overlay').style.height = evt.height;
}.bind(this);
- $('extension-options-overlay').appendChild(extensionoptions);
+ $('extension-options-overlay-guest').appendChild(extensionoptions);
$('extension-options-overlay-title').textContent = extensionName;

Powered by Google App Engine
This is Rietveld 408576698