Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2502)

Unified Diff: chrome/browser/extensions/extension_webui_apitest.cc

Issue 490783002: Handle closing web contents in ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/guest_view/extension_options/extension_options_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_webui_apitest.cc
diff --git a/chrome/browser/extensions/extension_webui_apitest.cc b/chrome/browser/extensions/extension_webui_apitest.cc
index fafaa59a9bce1938510343ec1abf6b194cf00a7e..7d3fb8f2438290f9c0c51e22dccb335cfc96d581 100644
--- a/chrome/browser/extensions/extension_webui_apitest.cc
+++ b/chrome/browser/extensions/extension_webui_apitest.cc
@@ -223,6 +223,24 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebUITest, CanEmbedExtensionOptions) {
ASSERT_TRUE(listener->WaitUntilSatisfied());
}
+IN_PROC_BROWSER_TEST_F(ExtensionWebUITest, ReceivesExtensionOptionsOnClose) {
+ scoped_ptr<ExtensionTestMessageListener> listener(
+ new ExtensionTestMessageListener("ready", true));
+
+ const Extension* extension =
+ InstallExtension(test_data_dir_.AppendASCII("extension_options")
+ .AppendASCII("close_self"), 1);
+ ASSERT_TRUE(extension);
+
+ ASSERT_TRUE(
+ RunTestOnExtensionsFrame("receives_extension_options_on_close.js"));
+
+ ASSERT_TRUE(listener->WaitUntilSatisfied());
+ listener->Reply(extension->id());
+ listener.reset(new ExtensionTestMessageListener("onclose received", false));
+ ASSERT_TRUE(listener->WaitUntilSatisfied());
+}
+
} // namespace
} // namespace extensions
« no previous file with comments | « no previous file | chrome/browser/guest_view/extension_options/extension_options_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698