Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 490743002: Add --with_tags to enable git tag fetching. (Closed)

Created:
6 years, 4 months ago by szager1
Modified:
6 years, 4 months ago
Reviewers:
Michael Moss, hinoka
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Add --with_tags to enable git tag fetching. Needed for chromeos ebuild. BUG=chromium:376027 R=mmoss@chromium.org,hinoka@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M gclient.py View 1 chunk +2 lines, -0 lines 0 comments Download
M gclient_scm.py View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
szager1
6 years, 4 months ago (2014-08-19 22:40:41 UTC) #1
Michael Moss
lgtm
6 years, 4 months ago (2014-08-19 22:46:19 UTC) #2
szager1
The CQ bit was checked by szager@chromium.org
6 years, 4 months ago (2014-08-19 22:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/490743002/1
6 years, 4 months ago (2014-08-19 22:47:28 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 22:49:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290683

Powered by Google App Engine
This is Rietveld 408576698