Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: components/variations.gypi

Issue 490733002: Remove dependency of common on variations browser code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test binary Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tests.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations.gypi
diff --git a/components/variations.gypi b/components/variations.gypi
index c3589aea4ba12150939c4324d7cb59f6bbdf4d33..30b11a70227f1a0f8284205a9f55e2d07c94c6c4 100644
--- a/components/variations.gypi
+++ b/components/variations.gypi
@@ -2,6 +2,9 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# List of dependencies is intentionally very minimal. Please avoid adding extra
+# dependencies without first checking with OWNERS.
Alexei Svitkine (slow) 2014/08/21 21:36:34 Nit: I was thinking this can be within the depende
scottmg 2014/08/21 21:40:38 Done.
+
{
'targets': [
{
@@ -14,7 +17,6 @@
'dependencies': [
'../base/base.gyp:base',
'../third_party/mt19937ar/mt19937ar.gyp:mt19937ar',
- 'components.gyp:google_core_browser',
],
'sources': [
'variations/active_field_trials.cc',
@@ -41,8 +43,6 @@
'variations/study_filtering.h',
'variations/variations_associated_data.cc',
'variations/variations_associated_data.h',
- 'variations/variations_http_header_provider.cc',
- 'variations/variations_http_header_provider.h',
'variations/variations_seed_processor.cc',
'variations/variations_seed_processor.h',
'variations/variations_seed_simulator.cc',
@@ -61,6 +61,23 @@
}],
],
},
+ {
+ # GN version: //components/variations_http_provider
+ 'target_name': 'variations_http_provider',
+ 'type': 'static_library',
+ 'include_dirs': [
+ '..',
+ ],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ 'components.gyp:google_core_browser',
+ 'variations',
+ ],
+ 'sources': [
+ 'variations/variations_http_header_provider.cc',
+ 'variations/variations_http_header_provider.h',
+ ],
+ },
],
'conditions': [
['OS=="android"', {
« no previous file with comments | « components/components_tests.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698