Remove dependency of common on variations browser code

components/variations.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
-      # GN version: //components/variations
-      'target_name': 'variations',
+      # GN version: //components/variations_common
+      'target_name': 'variations_common',

[Alexei Svitkine (slow), 2014/08/21 21:07:10]

I'd keep this as 'variations'.

[scottmg, 2014/08/21 21:21:48]

Done.

(Was based on many other components (see chrome_common) having a similar naming
scheme.)

       'type': 'static_library',
       'include_dirs': [
         '..',
       ],
       'dependencies': [
         '../base/base.gyp:base',

[Alexei Svitkine (slow), 2014/08/21 21:07:10]

Would you mind adding the following comment at the top of the file? (To avoid
this library accidentally getting more dependencies as it happened in the case
with the header provider.)

# List of dependencies is intentionally very minimal. Please avoid adding extra
# dependencies without first checking with OWNERS.

[scottmg, 2014/08/21 21:21:48]

Done.

         '../third_party/mt19937ar/mt19937ar.gyp:mt19937ar',
-        'components.gyp:google_core_browser',
       ],
       'sources': [
         'variations/active_field_trials.cc',
         'variations/active_field_trials.h',
         'variations/android/component_jni_registrar.cc',
         'variations/android/component_jni_registrar.h',
         'variations/android/variations_associated_data_android.cc',
         'variations/android/variations_associated_data_android.h',
         'variations/caching_permuted_entropy_provider.cc',
         'variations/caching_permuted_entropy_provider.h',
         'variations/entropy_provider.cc',
         'variations/entropy_provider.h',
         'variations/metrics_util.cc',
         'variations/metrics_util.h',
         'variations/pref_names.cc',
         'variations/pref_names.h',
         'variations/processed_study.cc',
         'variations/processed_study.h',
         'variations/proto/client_variations.proto',
         'variations/proto/permuted_entropy_cache.proto',
         'variations/proto/study.proto',
         'variations/proto/variations_seed.proto',
         'variations/study_filtering.cc',
         'variations/study_filtering.h',
         'variations/variations_associated_data.cc',
         'variations/variations_associated_data.h',
-        'variations/variations_http_header_provider.cc',
-        'variations/variations_http_header_provider.h',
         'variations/variations_seed_processor.cc',
         'variations/variations_seed_processor.h',
         'variations/variations_seed_simulator.cc',
         'variations/variations_seed_simulator.h',
       ],
       'variables': {
         'proto_in_dir': 'variations/proto',
         'proto_out_dir': 'components/variations/proto',
       },
       'includes': [ '../build/protoc.gypi' ],
       'conditions': [
         ['OS == "android"', {
           'dependencies': [
             'variations_jni_headers',
           ],
         }],
       ],
     },
+    {
+      # GN version: //components/variations
+      'target_name': 'variations',

[Alexei Svitkine (slow), 2014/08/21 21:07:10]

I'd name this variations_http_provider, since that's the only thing it has at
this point. (I can revisit the name if/when more files are added to this
target).

Then, only chrome/browser that needs it can depend on this (in addition to the
variations target, since that's needed because chrome/browser still uses its
protos.)

[scottmg, 2014/08/21 21:21:48]

Done.

+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+      ],
+      'dependencies': [
+        '../base/base.gyp:base',
+        '../third_party/mt19937ar/mt19937ar.gyp:mt19937ar',

[Alexei Svitkine (slow), 2014/08/21 21:07:10]

I don't think this dependency is needed.

[scottmg, 2014/08/21 21:21:48]

Done.

+        'components.gyp:google_core_browser',
+        'variations_common',
+      ],
+      'sources': [
+        'variations/variations_http_header_provider.cc',
+        'variations/variations_http_header_provider.h',
+      ],
+    },
   ],
   'conditions': [
     ['OS=="android"', {
       'targets': [
         {
           'target_name': 'variations_java',
           'type': 'none',
           'dependencies': [
             '../base/base.gyp:base',
           ],
@@ skipping 10 matching lines @@
           ],
           'variables': {
             'jni_gen_package': 'variations',
           },
           'includes': [ '../build/jni_generator.gypi' ],
         },
       ],
     }],
   ]
 }