Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Issue 490683002: Add --options to nanobench, similar to --key but for non-identifying options. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add --options to nanobench, similar to --key but for non-identifying options. Friends with https://codereview.chromium.org/487233003/ Example of out/Release/nanobench --options build_number 12374 --match patch_grid_texs_small { "gitHash":"unknown-revision", "options":{ "build_number":"12374", "system":"UNIX" }, "results":{ "patch_grid_texs_small_640_480":{ "565":{ "max_ms":0.268116, "mean_ms":0.2318529, "median_ms":0.235337, "min_ms":0.219158, "options":{ "source_type":"bench" }, "stddev_ms":0.01491263917658814 }, "8888":{ "max_ms":0.231881, "mean_ms":0.2214668, "median_ms":0.219356, "min_ms":0.218887, "options":{ "source_type":"bench" }, "stddev_ms":0.004595541070791701 }, "gpu":{ "max_ms":0.1398304782608696, "mean_ms":0.128833402173913, "median_ms":0.1316798695652174, "min_ms":0.1111915434782609, "options":{ "GL_RENDERER":"Quadro 600/PCIe/SSE2", "GL_SHADING_LANGUAGE_VERSION":"4.40 NVIDIA via Cg compiler", "GL_VENDOR":"NVIDIA Corporation", "GL_VERSION":"4.4.0 NVIDIA 331.79", "source_type":"bench" }, "stddev_ms":0.008923738937837156 } } } } BUG=skia: Committed: https://skia.googlesource.com/skia/+/94e51567dd691c3e1e8dfa6005a301d72cecf48e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M bench/nanobench.cpp View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 4 months ago (2014-08-19 19:29:44 UTC) #1
jcgregorio
On 2014/08/19 19:29:44, mtklein wrote: LGTM
6 years, 4 months ago (2014-08-19 19:34:31 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-19 19:34:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/490683002/1
6 years, 4 months ago (2014-08-19 19:35:12 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 19:42:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 94e51567dd691c3e1e8dfa6005a301d72cecf48e

Powered by Google App Engine
This is Rietveld 408576698