Issue 490673006: [turbofan] Add support for Finish to the InstructionSelector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 490673006: [turbofan] Add support for Finish to the InstructionSelector. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Add support for Finish to the InstructionSelector. Also fix an off-by-one bug in the handling of Parameter nodes, and improve test coverage for pointer map computation. TEST=compiler-unittest R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23219

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+237 lines, -15 lines)			Patch
M	src/compiler/instruction-selector.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/instruction-selector.cc	View	4 chunks	+32 lines, -14 lines	0 comments	Download
M	test/compiler-unittests/instruction-selector-unittest.h	View	3 chunks	+11 lines, -1 line	0 comments	Download
M	test/compiler-unittests/instruction-selector-unittest.cc	View	5 chunks	+193 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 4 months ago (2014-08-20 09:16:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23219 (presubmit successful).

Expand Messages | Collapse Messages