Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 490673002: Make PrivetLocalPrinterTest.PrinterAddedTest accept multiple query packets (Closed)

Created:
6 years, 4 months ago by Noam Samuel
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make PrivetLocalPrinterTest.PrinterAddedTest accept multiple query packets Make PrivetLocalPrinterTest accept 2 or more query packets (as opposed to exactly 2) being sent. This should solve flakiness in slow execution. BUG=405040 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/local_discovery/privet_local_printer_lister_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Noam Samuel
6 years, 4 months ago (2014-08-19 19:17:00 UTC) #1
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-19 19:20:42 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 4 months ago (2014-08-19 19:20:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/490673002/1
6 years, 4 months ago (2014-08-19 19:21:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 20:39:15 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 20:49:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290660

Powered by Google App Engine
This is Rietveld 408576698