Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.h

Issue 49063012: [rAC, OSX] Use bubble windows for error messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix failing tests. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/base_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.h b/chrome/browser/ui/cocoa/base_bubble_controller.h
index b2c0e720470f2fb5357ba0404f2eaab3397cad98..187a0cdd8b23431a8fcdf7117f732ad2eff3fb5b 100644
--- a/chrome/browser/ui/cocoa/base_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/base_bubble_controller.h
@@ -37,7 +37,9 @@ class TabStripModelObserverBridge;
id resignationObserver_;
// The controlled window should be the key window when it's opened. True by
// default.
- bool shouldOpenAsKeyWindow_;
Robert Sesek 2013/11/06 23:06:03 Thanks for this fix.
+ BOOL shouldOpenAsKeyWindow_;
+ // The bubble window should close if it (or its parent) resigns key status.
+ BOOL shouldCloseOnResignKey_;
}
@property(nonatomic, readonly) NSWindow* parentWindow;
@@ -45,7 +47,9 @@ class TabStripModelObserverBridge;
// arrow tip points.
@property(nonatomic, assign) NSPoint anchorPoint;
@property(nonatomic, readonly) InfoBubbleView* bubble;
-@property(nonatomic, assign) bool shouldOpenAsKeyWindow;
+@property(nonatomic, assign) BOOL shouldOpenAsKeyWindow;
+// Controls if the bubble auto-closes if the user clicks outside the bubble.
+@property(nonatomic, assign) BOOL shouldCloseOnResignKey;
// Creates a bubble. |nibPath| is just the basename, e.g. @"FirstRunBubble".
// |anchoredAt| is in screen space. You need to call -showWindow: to make the

Powered by Google App Engine
This is Rietveld 408576698