Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.mm

Issue 49063012: [rAC, OSX] Use bubble windows for error messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/autofill/autofill_error_bubble_controller.mm ('K') | « chrome/browser/ui/cocoa/autofill/autofill_error_bubble_controller_unittest.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/base_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm
index fad938f381753510dd6ebe7abd54b47d80ef7c56..9e0d556f95e9488daea8638b59d853e5fc233721 100644
--- a/chrome/browser/ui/cocoa/base_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm
@@ -205,11 +205,13 @@
object:window];
// The eventTap_ catches clicks within the application that are outside the
- // window.
+ // window. This only matters if the window is key.
Robert Sesek 2013/11/04 23:49:18 I'd put this comment closer to where this is imple
groby-ooo-7-16 2013/11/05 00:51:48 Done.
eventTap_ = [NSEvent
addLocalMonitorForEventsMatchingMask:NSLeftMouseDownMask
handler:^NSEvent* (NSEvent* event) {
if (event.window != window) {
+ if (![window isKeyWindow])
Robert Sesek 2013/11/04 23:49:18 Comment please.
groby-ooo-7-16 2013/11/05 00:51:48 Done.
+ return event;
Robert Sesek 2013/11/04 23:49:18 nit: blank line after.
groby-ooo-7-16 2013/11/05 00:51:48 Done.
// Call via the runloop because this block is called in the
// middle of event dispatch.
[self performSelector:@selector(windowDidResignKey:)
« chrome/browser/ui/cocoa/autofill/autofill_error_bubble_controller.mm ('K') | « chrome/browser/ui/cocoa/autofill/autofill_error_bubble_controller_unittest.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698