Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2143)

Unified Diff: mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl

Issue 490623003: Add JS bindings validation logic for non-nullable types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/js/bindings/validator.js ('k') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl
diff --git a/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl
index d7f7f84e69346897cda13c715dda1514300b97b3..f83f79d476cd6f45f9ead43910dd31f6db6b1790 100644
--- a/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl
+++ b/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl
@@ -33,7 +33,7 @@
{%- set field_name = packed_field.field.name %}
{%- if packed_field.field|is_string_pointer_field %}
// validate {{struct.name}}.{{field_name}}
- err = messageValidator.validateStringPointer({{packed_field|field_offset}})
+ err = messageValidator.validateStringPointer({{packed_field|validate_string_params}})
{%- elif packed_field.field|is_array_pointer_field %}
// validate {{struct.name}}.{{field_name}}
err = messageValidator.validateArrayPointer({{packed_field|validate_array_params}});
@@ -42,7 +42,7 @@
err = messageValidator.validateStructPointer({{packed_field|validate_struct_params}});
{%- elif packed_field.field|is_handle_field %}
// validate {{struct.name}}.{{field_name}}
- err = messageValidator.validateHandle({{packed_field|field_offset}})
+ err = messageValidator.validateHandle({{packed_field|validate_handle_params}})
{%- endif %}
if (err !== validator.validationError.NONE)
return err;
« no previous file with comments | « mojo/public/js/bindings/validator.js ('k') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698