Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: mojo/public/js/bindings/validation_unittests.js

Issue 490623003: Add JS bindings validation logic for non-nullable types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/js/bindings/codec.js ('k') | mojo/public/js/bindings/validator.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/js/bindings/validation_unittests.js
diff --git a/mojo/public/js/bindings/validation_unittests.js b/mojo/public/js/bindings/validation_unittests.js
index adb5d57d1a467c038bb7c1c32935526322e19a16..be07ac97a08121c014be3f77b51accecadd7519e 100644
--- a/mojo/public/js/bindings/validation_unittests.js
+++ b/mojo/public/js/bindings/validation_unittests.js
@@ -208,13 +208,6 @@ define([
continue;
}
- // TODO(hansmuller): Temporarily skipping array unexpected null tests.
- if (testFiles[i].indexOf("unexpected_null") != -1 ||
- testFiles[i].indexOf("unexpected_invalid") != -1) {
- console.log("[Skipping " + testFiles[i] + "]");
- continue;
- }
-
var testMessage = readTestMessage(testFiles[i]);
var handles = new Array(testMessage.handleCount);
var message = new codec.Message(testMessage.buffer, handles);
« no previous file with comments | « mojo/public/js/bindings/codec.js ('k') | mojo/public/js/bindings/validator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698