mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl - Issue 490623003: Add JS bindings validation logic for non-nullable types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl

Issue 490623003: Add JS bindings validation logic for non-nullable types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/js/bindings/validator.js ('K') | « mojo/public/js/bindings/validator.js ('k') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('j') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl

index d7f7f84e69346897cda13c715dda1514300b97b3..f83f79d476cd6f45f9ead43910dd31f6db6b1790 100644

--- a/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl

@@ -33,7 +33,7 @@

{%- set field_name = packed_field.field.name %}

{%- if packed_field.field|is_string_pointer_field %}

// validate {{struct.name}}.{{field_name}}

- err = messageValidator.validateStringPointer({{packed_field|field_offset}})

+ err = messageValidator.validateStringPointer({{packed_field|validate_string_params}})

{%- elif packed_field.field|is_array_pointer_field %}

// validate {{struct.name}}.{{field_name}}

err = messageValidator.validateArrayPointer({{packed_field|validate_array_params}});

@@ -42,7 +42,7 @@

err = messageValidator.validateStructPointer({{packed_field|validate_struct_params}});

{%- elif packed_field.field|is_handle_field %}

// validate {{struct.name}}.{{field_name}}

- err = messageValidator.validateHandle({{packed_field|field_offset}})

+ err = messageValidator.validateHandle({{packed_field|validate_handle_params}})

{%- endif %}

if (err !== validator.validationError.NONE)

return err;